[Lldb-commits] [PATCH] D66863: [lldb] Unify target checking in CommandObject

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 30 08:53:08 PDT 2019


clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

Just a few string reflows and fix a typo



================
Comment at: lldb/source/Commands/CommandObjectBreakpointCommand.cpp:593
+      : CommandObjectParsed(interpreter, "list",
+                            "List the script or set of  commands to be "
+                            "executed when the breakpoint is hit.",
----------------
replace multiple spaces with just one


================
Comment at: lldb/source/Commands/CommandObjectTarget.cpp:2615-2617
+            "Set the load addresses for "
+            "one or more sections in a "
+            "target module.",
----------------
Fix string


================
Comment at: lldb/source/Commands/CommandObjectWatchpointCommand.cpp:552-554
+                            "List the script or set of "
+                            "commands to be executed when "
+                            "the watchpoint is hit.",
----------------
reflow the string


================
Comment at: lldb/source/Interpreter/CommandObject.cpp:929
+Target &CommandObject::GetSelectedTarget() {
+  assert(m_flags.AnySe(eCommandRequiresTarget | eCommandProcessMustBePaused |
+                       eCommandProcessMustBeLaunched | eCommandRequiresFrame |
----------------
s/AnySe/AnySet/


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66863/new/

https://reviews.llvm.org/D66863





More information about the lldb-commits mailing list