[Lldb-commits] [PATCH] D66863: [lldb] Unify target checking in CommandObject

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 30 06:32:48 PDT 2019


teemperor updated this revision to Diff 218084.
teemperor added a comment.

- Removed target requirement where we already have another flag that's implying that we need a target.
- Properly formatted some strings.
- Extended check in GetSelectedTarget to also check for flags that imply eCommandRequiresTarget.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66863/new/

https://reviews.llvm.org/D66863

Files:
  lldb/include/lldb/Interpreter/CommandObject.h
  lldb/source/Commands/CommandObjectBreakpointCommand.cpp
  lldb/source/Commands/CommandObjectDisassemble.cpp
  lldb/source/Commands/CommandObjectProcess.cpp
  lldb/source/Commands/CommandObjectTarget.cpp
  lldb/source/Commands/CommandObjectThread.cpp
  lldb/source/Commands/CommandObjectWatchpoint.cpp
  lldb/source/Commands/CommandObjectWatchpointCommand.cpp
  lldb/source/Interpreter/CommandObject.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66863.218084.patch
Type: text/x-patch
Size: 87832 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190830/9832c2f2/attachment-0001.bin>


More information about the lldb-commits mailing list