[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

[Konrad Wilhelm Kleine via Phabricator via lldb-commits]

kwk updated this revision to Diff 217894.
kwk marked 4 inline comments as done.
kwk added a comment.

- Apply review comments
- Move LZMA logic to lldb/Host/LZMA.h as suggested by labath
- Simplify LZMA function signatures
- Remove LZMA_OK from switch
- Add llvm-nm to the list of lldb test dependencies as it is needed by the minidebuginfo test
- Use llvm-nm and llvm-strip in minidebuginfo test


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66791/new/

https://reviews.llvm.org/D66791

Files:
  lldb/include/lldb/Host/LZMA.h
  lldb/packages/Python/lldbsuite/test/linux/minidebuginfo/Makefile
  lldb/packages/Python/lldbsuite/test/linux/minidebuginfo/TestMiniDebugInfo.py
  lldb/packages/Python/lldbsuite/test/linux/minidebuginfo/main.c
  lldb/packages/Python/lldbsuite/test/make/Makefile.rules
  lldb/source/Host/CMakeLists.txt
  lldb/source/Host/common/LZMA.cpp
  lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
  lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.h
  lldb/source/Plugins/SymbolVendor/ELF/SymbolVendorELF.cpp
  lldb/test/CMakeLists.txt
  llvm/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66791.217894.patch
Type: text/x-patch
Size: 21262 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190829/da8d0958/attachment-0001.bin>