[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.
Shafik Yaghmour via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Aug 27 11:01:22 PDT 2019
shafik added inline comments.
Comment at: llvm/include/llvm/Support/MathExtras.h:271
unsigned char out[sizeof(Val)];
- std::memcpy(in, &Val, sizeof(Val));
+ memcpy(in, &Val, sizeof(Val));
for (unsigned i = 0; i < sizeof(Val); ++i)
What are you building on that `memcpy` is not in the `std` namespace? This is non-conforming.
C standard library headers provided by `cname` headers have their functions within the `std` namespace and it is unspecified whether these names are available in the global namespace. See [headers p5](http://eel.is/c++draft/headers#5).
Also it is not consistent since the `memcpy` below is left as-is. Why does one trigger the warning and not the other?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits