[Lldb-commits] [PATCH] D66655: [lldb] Fix x86 compilation

Tatyana Krasnukha via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sat Aug 24 09:03:59 PDT 2019


tatyana-krasnukha added inline comments.


================
Comment at: source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_i386.h:9
 
-#if defined(_WIN64)
+#if defined(_WIN32) && !defined(_WIN64)
 #ifndef liblldb_NativeRegisterContextWindows_i386_h_
----------------
These macros are also defined when the compilation target is ARM.
I'd use `#if defined(__i386__) || defined(_M_IX86)` instead.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66655/new/

https://reviews.llvm.org/D66655





More information about the lldb-commits mailing list