[Lldb-commits] [PATCH] D66250: [JIT][Unwinder] Add Trampoline ObjectFile and UnwindPlan support for FCB

Thu Aug 22 23:01:00 PDT 2019

jasonmolenda added inline comments.

================
Comment at: lldb/source/Target/ABI.cpp:10
 #include "lldb/Target/ABI.h"
+#include "Plugins/ObjectFile/Trampoline/ObjectFileTrampoline.h"
+#include "lldb/Core/Module.h"
----------------
mib wrote:
> labath wrote:
> > If this is going to be something that is called directly from core lldb code, then it not a "plugin" by any stretch of imagination. I think we should put this file some place else.
> Any suggestion on where to put it ?
Maybe in source/Symbol along with the ObjectFile.cpp base class.  I agree with Pavel that this isn't a plugin; it subclasses ObjectFile so it probably has to implement the plugin methods, but it's not something that will ever be created by iterating through the active ObjectFile plugins or anything like that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66250/new/

https://reviews.llvm.org/D66250