[Lldb-commits] [lldb] r369731 - [LLDB] Address post-commit code review feedback.

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Thu Aug 22 21:11:38 PDT 2019


Author: jdevlieghere
Date: Thu Aug 22 21:11:38 2019
New Revision: 369731

URL: http://llvm.org/viewvc/llvm-project?rev=369731&view=rev
Log:
[LLDB] Address post-commit code review feedback.

This patch addresses Adrian McCarthy's code review feedback in
https://reviews.llvm.org/D66447

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/char8_t/main.cpp
    lldb/trunk/source/Symbol/ClangASTContext.cpp

Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/char8_t/main.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/char8_t/main.cpp?rev=369731&r1=369730&r2=369731&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/char8_t/main.cpp (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/char8_t/main.cpp Thu Aug 22 21:11:38 2019
@@ -1,5 +1,3 @@
-#include <cstring>
-
 char8_t a  = u8'a';
 const char8_t* ab = u8"你好";
 char8_t abc[9] = u8"你好";

Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/ClangASTContext.cpp?rev=369731&r1=369730&r2=369731&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/ClangASTContext.cpp (original)
+++ lldb/trunk/source/Symbol/ClangASTContext.cpp Thu Aug 22 21:11:38 2019
@@ -1390,9 +1390,9 @@ CompilerType ClangASTContext::GetBuiltin
       if (type_name) {
         if (streq(type_name, "char16_t"))
           return CompilerType(this, ast->Char16Ty.getAsOpaquePtr());
-        else if (streq(type_name, "char32_t"))
+        if (streq(type_name, "char32_t"))
           return CompilerType(this, ast->Char32Ty.getAsOpaquePtr());
-        else if (streq(type_name, "char8_t"))
+        if (streq(type_name, "char8_t"))
           return CompilerType(this, ast->Char8Ty.getAsOpaquePtr());
       }
       break;




More information about the lldb-commits mailing list