[Lldb-commits] [PATCH] D66445: Explicitly Cast Constants to DWORD

[Aaron Smith via lldb-commits]

The reason for the define is it’s not possible currently to include winnt.h without build errors. Definitely something to cleanup.

> On Aug 22, 2019, at 9:47 AM, Gwen Mittertreiner via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> jmittert added a comment.
> 
> I believe it's using the one in ntstatus.h
> 
>  10.0.16299.0\shared\ntstatus.h
>  #define STATUS_BREAKPOINT                ((NTSTATUS)0x80000003L)    // winnt
> 
> And `NTSTATUS` is defined as a `LONG` in powerbase.h
> 
>  10.0.16299.0\um\powerbase.h
>  #define NTSTATUS LONG
> 
> which would make it a signed (negative) number.
> 
> 
> Repository:
>  rLLDB LLDB
> 
> CHANGES SINCE LAST ACTION
>  https://reviews.llvm.org/D66445/new/
> 
> https://reviews.llvm.org/D66445
> 
> 
>