[Lldb-commits] [PATCH] D66447: Add char8_t support (C++20)

[Adrian McCarthy via Phabricator via lldb-commits]

amccarth added a comment.

A couple inline comments.  I think this is looking pretty good.



================
Comment at: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/char8_t/main.cpp:1
+#include <cstring>
+
----------------
Is this include necessary?


================
Comment at: lldb/trunk/source/Symbol/ClangASTContext.cpp:1391
           return CompilerType(this, ast->Char32Ty.getAsOpaquePtr());
-        }
+        else if (streq(type_name, "char8_t"))
+          return CompilerType(this, ast->Char8Ty.getAsOpaquePtr());
----------------
I think the current style is to omit the `else` keywords on these, since each `if` returns.  That would at least be consistent with several cases above.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66447/new/

https://reviews.llvm.org/D66447