[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language
Adrian Prantl via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Aug 22 10:46:38 PDT 2019
aprantl added a comment.
> Looks good overall. Just a question of it we want to return "const LanguageSet &" to avoid copies. Also switch static functions that currently return "LanguageSet" over to use static variables and llvm::once to init them and then return "const LanguageSet &".
The point of the static_assert in TypeSystem.cpp is to make sure that a LanguageSet is exactly 64 bits in size so it is cheap to pass it by value.
CHANGES SINCE LAST ACTION
More information about the lldb-commits