[Lldb-commits] [PATCH] D66581: [lldb] Construct the dummy target when the first Dummy object is constructed

[Jim Ingham via Phabricator via lldb-commits]

jingham accepted this revision.
jingham added a comment.

You can go a long time without actually using the Dummy target, which is why I made it lazily.

Thinking of lldb as the command line program, we tend to think "I'll only ever make one debugger" so making one extra per-debugger thing doesn't seem very important.  But since the Debugger holds the Console, most UI's make one Debugger per debugging session, and may have many of them.  So if making the one-per-debugger thing is not trivial, you do need to think a little harder about the cost.

OTOH, as Pavel says, a target with no executables that never connects to any platforms, or gets any expressions run in it, should be really cheap.  So I'm fine with this change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66581/new/

https://reviews.llvm.org/D66581