[Lldb-commits] [lldb] r369652 - [lldb][NFC] Fix indentation in CommandObjectProcess

Alexander Kornienko via lldb-commits lldb-commits at lists.llvm.org
Thu Aug 22 08:41:12 PDT 2019


Thanks for the quick fix!

On Thu, Aug 22, 2019 at 5:29 PM Raphael “Teemperor” Isemann <
teemperor at gmail.com> wrote:

> Fix is already committed as 369660, sorry for that.
> - Raphael
>
> On Aug 22, 2019, at 5:28 PM, Alexander Kornienko via lldb-commits <
> lldb-commits at lists.llvm.org> wrote:
>
> This commit breaks buildbots:
> http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/8107
>
> On Thu, Aug 22, 2019 at 3:49 PM Raphael Isemann via lldb-commits <
> lldb-commits at lists.llvm.org> wrote:
>
>> Author: teemperor
>> Date: Thu Aug 22 06:50:54 2019
>> New Revision: 369652
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=369652&view=rev
>> Log:
>> [lldb][NFC] Fix indentation in CommandObjectProcess
>>
>> Modified:
>>     lldb/trunk/source/Commands/CommandObjectProcess.cpp
>>
>> Modified: lldb/trunk/source/Commands/CommandObjectProcess.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectProcess.cpp?rev=369652&r1=369651&r2=369652&view=diff
>>
>> ==============================================================================
>> --- lldb/trunk/source/Commands/CommandObjectProcess.cpp (original)
>> +++ lldb/trunk/source/Commands/CommandObjectProcess.cpp Thu Aug 22
>> 06:50:54 2019
>> @@ -348,15 +348,15 @@ public:
>>              partial_name, FileSpec::Style::native);
>>          match_info.SetNameMatchType(NameMatch::StartsWith);
>>        }
>> -          platform_sp->FindProcesses(match_info, process_infos);
>> -          const size_t num_matches = process_infos.GetSize();
>> -          if (num_matches == 0)
>> -            return;
>> -          for (size_t i = 0; i < num_matches; ++i) {
>> -            request.AddCompletion(
>> -                llvm::StringRef(process_infos.GetProcessNameAtIndex(i),
>> -
>> process_infos.GetProcessNameLengthAtIndex(i)));
>> -          }
>> +      platform_sp->FindProcesses(match_info, process_infos);
>> +      const size_t num_matches = process_infos.GetSize();
>> +      if (num_matches == 0)
>> +        return;
>> +      for (size_t i = 0; i < num_matches; ++i) {
>> +        request.AddCompletion(
>> +            llvm::StringRef(process_infos.GetProcessNameAtIndex(i),
>> +
>> process_infos.GetProcessNameLengthAtIndex(i))));
>> +      }
>>      }
>>
>>      // Instance variables to hold the values for command options.
>>
>>
>> _______________________________________________
>> lldb-commits mailing list
>> lldb-commits at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190822/7f76ba79/attachment-0001.html>


More information about the lldb-commits mailing list