[Lldb-commits] [PATCH] D66581: [lldb] Construct the dummy target when the first Dummy object is constructed
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Aug 22 03:55:35 PDT 2019
labath added a reviewer: jingham.
labath accepted this revision.
labath added a subscriber: jingham.
labath added a comment.
This revision is now accepted and ready to land.
This looks good to me (I wanted to do something like that myself at one point), but maybe let @jingham have a say too. (Overall, I would say that shouldn't be any reason why constructing a dummy target should ever fail, nor a reason for its creation to consume a large chunk of any kind of resource, so we can save ourselves a lot of second-guessing by just ensuring that the dummy target really always is there.)
Comment at: lldb/include/lldb/Core/Debugger.h:403
+ lldb::TargetSP m_dummy_target;
this would be `m_dummy_target_sp`, according to the lldb style.
CHANGES SINCE LAST ACTION
More information about the lldb-commits