[Lldb-commits] [PATCH] D66447: Add char8_t support (C++20)
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Aug 21 10:44:09 PDT 2019
labath added a comment.
In D66447#1639490 <https://reviews.llvm.org/D66447#1639490>, @JDevlieghere wrote:
> Sounds like I simply misunderstood your earlier comment. I thought you meant putting a full UTF-8 *character* in a `char8_t.
Ah yes, I can see how that request could have been interpreted this way. I'm glad that we understand each other.
>> However, this actually surfaces the question of how should we format single char8_t variables. It makes sense to display the character value if the value happens to be ASCII, but I guess we shouldn't print something like "invalid utf8 character" if it does contain one unit of the multibyte characters.
> What about the current implementation that prints both the hex and the ASCII value?
I think that's fine. lgtm.
CHANGES SINCE LAST ACTION
More information about the lldb-commits