[Lldb-commits] [PATCH] D66536: [lldb][NFC] Remove WordComplete mode, make result array indexed from 0 and remove any undocumented/redundant return values

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 21 07:47:52 PDT 2019


teemperor marked an inline comment as done.
teemperor added inline comments.


================
Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:1847
-
-  if (request.GetParsedLine().GetArgumentCount() == 0) {
-    // If we got an empty string, insert nothing.
----------------
Note that I moved this code to SBCommandInterpreter::HandleCompletionWithDescriptions (as it adds the common prefix in  element 0).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66536/new/

https://reviews.llvm.org/D66536





More information about the lldb-commits mailing list