[Lldb-commits] [PATCH] D66447: Add char8_t support (C++20)

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Aug 20 09:24:52 PDT 2019

JDevlieghere added a comment.

In D66447#1636456 <https://reviews.llvm.org/D66447#1636456>, @jblachly wrote:

> Thank you for creating a revision and reviewing this.
> I made inline comments on the test harness and Dlang types / qualifiers.
> With removal of the Dlang types, where is the appropriate place to put them?
>  It is not clear to me whether language plugins can replace the functionality in ClangASTContext::GetBuiltinTypeForDWARFEncodingAndBitSize.
> Thanks again

Thanks James. I removed the DLang part from this patch because it's orthogonal to the `char8_t` support. The changes might be fine but they really should have their own differential and test. I'll try to put up another patch later today if I find the time.



More information about the lldb-commits mailing list