[Lldb-commits] [PATCH] D66429: [CMake] Remove LLDB_TEST_USE_CUSTOM_C(XX)_COMPILER
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Aug 20 01:02:37 PDT 2019
labath added subscribers: stella.stamenova, labath.
labath added a comment.
I agree that the USE variables seem redundant. I remember thinking the same thing when they were introduced, but I was not objecting back then because there seemed to be a good reason for it. However, now I don't know what that reason was... Tagging @stella.stamenova in case she does (I know it had something to do with multi-config generators and visual studio).
That said, I'm not a fan of force-overwriting cache variables specified by the user, particularly when the same effect can be achieved by *deleting* the cache variable instead of setting it to an empty string. I think you should be able to reset the default value of `LLDB_TEST_C_COMPILER` (just like any other cmake variable) by running `cmake -ULLDB_TEST_C_COMPILER`. You can even delete both variables at once with `-ULLDB_TEST_*_COMPILER`.
CHANGES SINCE LAST ACTION
More information about the lldb-commits