[Lldb-commits] [PATCH] D66451: [ClangExpressionParser] Add ClangDeclVendor

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/include/lldb/Symbol/DeclVendor.h:27
+    eAppleObjCDeclVendor,
+    eLastClangDeclVendor,
+  };
----------------
xiaobai wrote:
> JDevlieghere wrote:
> > What's `eLastClangDeclVendor` and where is it used?
> Following the advice here: https://llvm.org/docs/HowToSetUpLLVMStyleRTTI.html
> 
> I added a Last one to indicate that any new ClangDeclVendor subclasses should go before this one. It also makes the classof pattern of checking bounds easier. (kind >= eFoo && kind < eLastFoo).
> 
> 
Fair enough, I totally forgot about that pattern. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66451/new/

https://reviews.llvm.org/D66451