[Lldb-commits] [PATCH] D66453: Make the FindTypes(std::vector<CompilerContext>, ...) API testable in lldb-test
Adrian Prantl via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Aug 19 17:34:00 PDT 2019
aprantl marked an inline comment as done.
aprantl added inline comments.
Comment at: lldb/tools/lldb-test/lldb-test.cpp:145
+ cl::desc("Specify a compiler context as \"[(type,name),...]\"."),
+ cl::value_desc("context"), cl::sub(SymbolsSubcommand));
> > ...as a JSON array...`
> This makes me wonder though, wouldn't it be better to pass a file here and have it live in inputs? Do you expect it to be different across tests or could we reuse the context across tests?
I don't really expect a DeclContexts to have more than 3 entries in the forseeable future, so that would arguable just make the test harder to read.
CHANGES SINCE LAST ACTION
More information about the lldb-commits