[Lldb-commits] [PATCH] D66398: 2/2: Fix `TestDataFormatterStdList` regression
Jan Kratochvil via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Aug 19 07:56:48 PDT 2019
jankratochvil added a comment.
In fact the whole patch is a oneliner (+`operator<` for `RegularExpression.h`):
- typedef FormattersContainer<lldb::RegularExpressionSP, FormatterImpl> RegexMatchContainer;
+ typedef FormattersContainer<RegularExpression, FormatterImpl> RegexMatchContainer;
The rest of the patch is just a mechanical update to make it compile again.
It was my mistake when trying to fix the `TestDataFormatterStdList` regression that it looked to me the new `RegularExpression` must be broken (its lifetime). In the end it was not broken. But along the way I have removed its IMO-excessive `Compile()` method as I am trying to push this API change as a cleanup in D66392 <https://reviews.llvm.org/D66392>. If there is disagreement I will rework this patch D66398 <https://reviews.llvm.org/D66398> to use the former `RegularExpression` API using `Compile()`. If there is disagreement even with that I can drop it all and just make a new comparison function for `lldb::RegularExpressionSP`.
CHANGES SINCE LAST ACTION
More information about the lldb-commits