[Lldb-commits] [PATCH] D66392: 1/2: D66174 `RegularExpression` cleanup

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil added a comment.

In D66392#1634575 <https://reviews.llvm.org/D66392#1634575>, @JDevlieghere wrote:

> I am aware the `llvm/` part of this patch needs an extra approval and this is why @jdevlieghere had there that:
>
>   std::string discarded;
>   return m_regex.isValid(discarded);
>   
>
> Is it complicated to get the `llvm/` extension approved? I can quickly drop any parts of this patch not considered as feasible.


I have put there plain `m_regex.isValid()` instead as with my patch `IsValid()` is called during every `Execute()` so `IsValid()` could become a bottleneck.  But then the `discarded` string is just 32 bytes on stack anyway so it should be cheap enough even without the `llvm/` extension.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66392/new/

https://reviews.llvm.org/D66392