[Lldb-commits] [lldb] r368154 - A more robust way of testing debug_line parser near the end of module

[Pavel Labath via lldb-commits]

Author: labath
Date: Wed Aug  7 04:33:56 2019
New Revision: 368154

URL: http://llvm.org/viewvc/llvm-project?rev=368154&view=rev
Log:
A more robust way of testing debug_line parser near the end of module

Summary:
While removing -z separate-code makes lld produce place the code at the
end of a segment right now, it's possible that future changes to the
linker will change that, thereby removing the coverage for the changes
in r367983. This patch adds a linker script to one of the line table
tests, which ensures that the code (and its line table) will be placed
at the very end of a module.

Reviewers: MaskRay

Subscribers: lldb-commits

Differential Revision: https://reviews.llvm.org/D65789

Added:
    lldb/trunk/lit/SymbolFile/DWARF/Inputs/debug-line-basic.script
Modified:
    lldb/trunk/lit/SymbolFile/DWARF/debug-line-basic.s

Added: lldb/trunk/lit/SymbolFile/DWARF/Inputs/debug-line-basic.script
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/lit/SymbolFile/DWARF/Inputs/debug-line-basic.script?rev=368154&view=auto
==============================================================================
--- lldb/trunk/lit/SymbolFile/DWARF/Inputs/debug-line-basic.script (added)
+++ lldb/trunk/lit/SymbolFile/DWARF/Inputs/debug-line-basic.script Wed Aug  7 04:33:56 2019
@@ -0,0 +1,14 @@
+PHDRS {
+  text PT_LOAD;
+}
+SECTIONS {
+  .shstrtab     : { *(.shstrtab    ) }
+  .debug_info   : { *(.debug_info  ) }
+  .debug_line   : { *(.debug_line  ) }
+  .debug_str    : { *(.debug_str   ) }
+  .debug_abbrev : { *(.debug_abbrev) }
+
+  . = 0x201000;
+  .text : { *(.text .text.f) } :text
+  /DISCARD/ : { *(*) }
+}

Modified: lldb/trunk/lit/SymbolFile/DWARF/debug-line-basic.s
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/lit/SymbolFile/DWARF/debug-line-basic.s?rev=368154&r1=368153&r2=368154&view=diff
==============================================================================
--- lldb/trunk/lit/SymbolFile/DWARF/debug-line-basic.s (original)
+++ lldb/trunk/lit/SymbolFile/DWARF/debug-line-basic.s Wed Aug  7 04:33:56 2019
@@ -1,10 +1,14 @@
+# Test basics of debug_line parsing. This test uses a linker script which
+# ensures the code is placed at the end of a module to test the boundary
+# condition when the final end-of-sequence line table entry points to an address
+# that is outside the range of memory covered by the module.
+
 # REQUIRES: lld, x86
 
 # RUN: llvm-mc -triple x86_64-pc-linux %s -filetype=obj > %t.o
-# RUN: ld.lld %t.o -o %t
+# RUN: ld.lld --script=%S/Inputs/debug-line-basic.script %t.o -o %t
 # RUN: %lldb %t -o "image dump line-table -v a.c" -o exit | FileCheck %s
 
-
 	.text
 	.globl	_start
 _start:
@@ -35,9 +39,16 @@ _start:
 	.loc   2 1 0 is_stmt 0
         nop
 # CHECK-NEXT: 0x0000000000201007: /tmp/c.c:1{{$}}
-
 # CHECK-NEXT: 0x0000000000201008: /tmp/c.c:1, is_terminal_entry = TRUE{{$}}
 
+	.section	.text.f,"ax", at progbits
+f:
+        .loc   1 3 0 is_stmt 0
+        nop
+# CHECK-NEXT: 0x0000000000201008: /tmp/b.c:3{{$}}
+# CHECK-NEXT: 0x0000000000201009: /tmp/b.c:3, is_terminal_entry = TRUE{{$}}
+
+
 	.section	.debug_str,"MS", at progbits,1
 .Linfo_string1:
 	.asciz	"a.c"