[Lldb-commits] [lldb] r368151 - [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project
Stefan Granitz via lldb-commits
lldb-commits at lists.llvm.org
Wed Aug 7 04:02:04 PDT 2019
Author: stefan.graenitz
Date: Wed Aug 7 04:02:04 2019
New Revision: 368151
URL: http://llvm.org/viewvc/llvm-project?rev=368151&view=rev
Log:
[lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project
Summary:
Explicitly code-sign the LLDB.framework copy of debugserver in the build-tree. This is necessary, because the Xcode-specific logic in `llvm_codesign` [1] has the side-effect that Xcode code-signs after post-build steps (here: after copying debugserver over into the framework). The special case for Xcode was necessary to avoid double-signing errors in the past (see D55116 and D55816).
[1] https://github.com/llvm/llvm-project/blob/36fb93982f0e/llvm/cmake/modules/AddLLVM.cmake#L1676
Reviewers: jingham, davide, JDevlieghere, teemperor
Reviewed By: JDevlieghere
Subscribers: beanz, mgorny, lldb-commits, #lldb
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D65566
Modified:
lldb/trunk/tools/debugserver/source/CMakeLists.txt
Modified: lldb/trunk/tools/debugserver/source/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/CMakeLists.txt?rev=368151&r1=368150&r2=368151&view=diff
==============================================================================
--- lldb/trunk/tools/debugserver/source/CMakeLists.txt (original)
+++ lldb/trunk/tools/debugserver/source/CMakeLists.txt Wed Aug 7 04:02:04 2019
@@ -208,6 +208,34 @@ add_lldb_tool(debugserver ADD_TO_FRAMEWO
ENTITLEMENTS ${entitlements}
)
+# Workaround for Xcode-specific code-signing behavior:
+# The XCODE_ATTRIBUTE_CODE_SIGN_IDENTITY option causes debugserver to be copied
+# into the framework first and code-signed afterwards. Sign the copy manually.
+if (debugserver_codesign_identity AND LLDB_BUILD_FRAMEWORK AND
+ CMAKE_GENERATOR STREQUAL "Xcode")
+ if(NOT CMAKE_CODESIGN_ALLOCATE)
+ execute_process(
+ COMMAND xcrun -f codesign_allocate
+ OUTPUT_STRIP_TRAILING_WHITESPACE
+ OUTPUT_VARIABLE CMAKE_CODESIGN_ALLOCATE
+ )
+ endif()
+ if(entitlements)
+ set(pass_entitlements --entitlements ${entitlements})
+ endif()
+
+ get_target_property(framework_build_dir liblldb LIBRARY_OUTPUT_DIRECTORY)
+ set(copy_location ${framework_build_dir}/LLDB.framework/Versions/${LLDB_FRAMEWORK_VERSION}/Resources/debugserver)
+
+ add_custom_command(TARGET debugserver POST_BUILD
+ COMMAND ${CMAKE_COMMAND} -E
+ env CODESIGN_ALLOCATE=${CMAKE_CODESIGN_ALLOCATE}
+ xcrun codesign -f -s ${debugserver_codesign_identity}
+ ${pass_entitlements} ${copy_location}
+ COMMENT "Code-sign debugserver copy in the build-tree framework: ${copy_location}"
+ )
+endif()
+
set_target_properties(debugserver PROPERTIES FOLDER "lldb libraries/debugserver")
if(IOS)
More information about the lldb-commits
mailing list