[Lldb-commits] [PATCH] D64395: [CMake] Avoid libcxxabi dependency when building LLDB from the monorepo on macOS by default

[Stefan Gränitz via Phabricator via lldb-commits]

sgraenitz added a comment.

Thanks for taking a look.

In D64395#1575967 <https://reviews.llvm.org/D64395#1575967>, @ldionne wrote:

> When is `LLDBConfig.cmake` used?


Very early in the LLDB config process: https://github.com/llvm/llvm-project/blob/e0a3ee79c5ff/lldb/CMakeLists.txt#L15
Globally, I think LLDB is always configured after libc++. Does libc++ make decisions based on these values?

> Will it influence whether `libc++.dylib` is built in the monorepo whenever you also happen to build LLDB?

Yes, I think so. Adding lldb to `LLVM_ENABLE_PROJECTS` will disable `libc++.dylib` globally, ...

> So when both libcxxabi and libcxx are enabled, we will build libc++.dylib and libc++.a? Why not always disable it?

... if and only if libcxxabi is not enabled. Thus the restriction.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64395/new/

https://reviews.llvm.org/D64395