[Lldb-commits] [PATCH] D64395: [CMake] Avoid libcxxabi dependency when building LLDB from the monorepo on macOS by default

[Louis Dionne via Phabricator via lldb-commits]

ldionne added a comment.

When is `LLDBConfig.cmake` used? I'm trying to understand when the `LIBCXX_ENABLE_SHARED=OFF` setting will come into play. Will it influence whether `libc++.dylib` is built in the monorepo whenever you also happen to build LLDB?



================
Comment at: lldb/cmake/modules/LLDBConfig.cmake:79
+  # if not enabled explicitly in builds from the monorepo.
+  if("libcxx" IN_LIST LLVM_ENABLE_PROJECTS AND NOT "libcxxabi" IN_LIST LLVM_ENABLE_PROJECTS)
+    set(LIBCXX_ENABLE_SHARED OFF CACHE BOOL "" FORCE)
----------------
So when both `libcxxabi` and `libcxx` are enabled, we will build `libc++.dylib` and `libc++.a`? Why not always disable it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64395/new/

https://reviews.llvm.org/D64395