[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX
Hubert Tong via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Jul 5 11:11:24 PDT 2019
hubert.reinterpretcast added inline comments.
Comment at: llvm/utils/lit/lit/LitConfig.py:98
+ self.fatal("Setting a timeout per test requires the"
+ " Python psutil module but it could not be"
+ " found. Try installing it via pip or via"
Minor nit: The quote indentation no longer lines up with the previous line.
Comment at: llvm/utils/lit/tests/lit.cfg:62
- lit_config.note('Found python psutil module')
Removing `python-psutil` as a feature entirely may be a bit aggressive. It has the potential of quietly disabling "out-of-tree" tests. I'm not sure that a Phabricator patch about AIX has the right level of visibility for making such a change. Can you send an RFC about the cleanup to the mailing list?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits