[Lldb-commits] [PATCH] D63868: Unify+fix remote XML libraries handling with the legacy one

Thu Jun 27 07:41:03 PDT 2019

aadsm added a comment.

I'm not sure why `DynamicLoaderPOSIXDYLD::RendezvousBreakpointHit` happens only once, I thought I had fixed that here: D62168 <https://reviews.llvm.org/D62168>.
I don't think we can stop loading/unloading the libraries in `ProcessGDBRemote::LoadModules`. The windows dynamic loader relies on this and the `library` entry on the stop packet does as well: https://github.com/llvm-mirror/lldb/blob/9689521b477c75b52257fba9655cabefc3db676c/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp#L2374-L2375

I actually proposed a different way of loading the libraries here (and it's faster because it reduces the generation of `libraries-svr4` in half): D62504 <https://reviews.llvm.org/D62504>. What do you think?

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63868/new/

https://reviews.llvm.org/D63868