[Lldb-commits] [PATCH] D63868: Unify+fix remote XML libraries handling with the legacy one

Thu Jun 27 04:06:22 PDT 2019

jankratochvil marked an inline comment as done.
jankratochvil added inline comments.

================
Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:185

-  // If we can't get the SO info from the remote, return failure.
-  if (fromRemote && m_process->LoadModules(module_list) == 0)
+  if (m_current.map_addr == 0)
     return false;
----------------
This change is not really required but I do not see why the `map_addr` check should differ when the remote XML protocol is in use.

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63868/new/

https://reviews.llvm.org/D63868