[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

[Alex Langford via Phabricator via lldb-commits]

xiaobai added a comment.

In D63240#1559913 <https://reviews.llvm.org/D63240#1559913>, @jingham wrote:

> Shouldn't ValueObjectVariables figure out their runtime language from their defining frame, not their CompilerType?  For a ValueObject you get from an expression, you probably can't do that.  But we're always talking about hiding locals or args here - i.e. they are all ValueObjectVariables.  And it seems to me that in that case getting the RuntimeLanguage from the containing frame is much more useful than from the CompilerType.


Does every variable have an associated frame? I imagine things like global variables wouldn't. I'm not sure if any language or implementation of a language has global variables as compiler/runtime helper variables, but I'm not comfortable making that assumption since one of my goals is more generalized language support.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63240/new/

https://reviews.llvm.org/D63240