[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

Shouldn't ValueObjectVariables figure out their runtime language from their defining frame, not their CompilerType?  For a ValueObject you get from an expression, you probably can't do that.  But we're always talking about hiding locals or args here - i.e. they are all ValueObjectVariables.  And it seems to me that in that case getting the RuntimeLanguage from the containing frame is much more useful than from the CompilerType.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63240/new/

https://reviews.llvm.org/D63240