[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jun 19 12:27:25 PDT 2019


clayborg added a comment.

my fix assumes we would have zero sized symbols first in the m_file_addr_to_index map, and the symbols with the same size would be ordered after the ones with zero size. Also, I am assuming when we do:

  const FileRangeToIndexMap::Entry *entry = m_file_addr_to_index.FindEntryStartsAt(file_addr);

that it finds the first symbol that starts with "file_addr". If this isn't the case we might need to be able to back up a few symbols to ensure we get consistent results


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63540/new/

https://reviews.llvm.org/D63540





More information about the lldb-commits mailing list