[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jun 19 12:23:54 PDT 2019


clayborg added a comment.

So I am fine with symbols having zero size being in the symbol table. I would be fine not changing anything in the sorting and leaving some symbols with zero size, we just need to fix:

  Symbol *Symtab::FindSymbolAtFileAddress(addr_t file_addr);

To ignore zero sized symbols when it finds them _if_ there is another symbol that has a size for that address. Wouldn't that fix the issue here?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63540/new/

https://reviews.llvm.org/D63540





More information about the lldb-commits mailing list