[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

[Wanyi Ye via Phabricator via lldb-commits]

kusmour added a comment.

@labath Hi, you're right about the `lld`, it didn't make the test pass, instead it became unsupported.

In D62213#1548835 <https://reviews.llvm.org/D62213#1548835>, @labath wrote:

> Can you elaborate on that? How exactly did it break this test?


So the problem here is that, `llvm-mc` constructs the Triple correctly, but lldb does not preserve all the information from it, at least it does not know about the OS type.

> Maybe we should make the SysV abi plugin match unknown oss too...

I'm not sure this is the right thing to do, but this should fix the problem.

> The only format where we have trouble determining the OS is ELF, and it's a pretty good bet that any elf file will be using the "SysV" ABI...

Can you provide more information about this? It sounds like a bug


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62213/new/

https://reviews.llvm.org/D62213