[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In D62213#1548788 <https://reviews.llvm.org/D62213#1548788>, @kusmour wrote:

> the OS check in SysV x64 ABI broke the test `SymbolFile/DWARF/debug_loc.s`


Can you elaborate on that? How exactly did it break this test?

> added a restriction `lld` to `#REQUIRES`

That definitely is not the right solution here. If you add lld to your checkout on windows, then "REQUIRES: lld" will be satisfied, but the test will (I guess) still fail. "XFAIL: system-windows" is probably what you want here, but it would be good to understand why this starts to fail now. Is it because we fail to detect that the file in question there is a linux file, and so the triple comes out like "x86_64--" or something? Maybe we should make the SysV abi plugin match unknown oss too... The only format where we have trouble determining the OS is ELF, and it's a pretty good bet that any elf file will be using the "SysV" ABI...


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62213/new/

https://reviews.llvm.org/D62213