[Lldb-commits] [PATCH] D63181: [Target] Decouple ObjCLanguageRuntime from LanguageRuntime

[Alex Langford via Phabricator via lldb-commits]

xiaobai marked an inline comment as done.
xiaobai added a comment.

In D63181#1539620 <https://reviews.llvm.org/D63181#1539620>, @labath wrote:

> Moving BreakpointPrecondition to a forward-declarable place sounds good to me.


Alright, so I think I'll go ahead and change this patch to make that happen. Thanks for your input! :)



================
Comment at: source/Target/ObjCLanguageRuntime.cpp:379
+void ObjCLanguageRuntime::SetBreakpointExceptionPrecondition(
+    BreakpointSP breakpoint, LanguageType language, bool throw_bp) {
+  if (!throw_bp)
----------------
labath wrote:
> Shouldn't you be checking the language here or something. Given that you're iterating over all plugins, won't this set the precondition unconditionally (:P) on all exception breakpoints?
It will! For some reason I added a `language` paramter but forgot to use it. Thanks for pointing that out.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63181/new/

https://reviews.llvm.org/D63181