[Lldb-commits] [PATCH] D63181: [Target] Decouple ObjCLanguageRuntime from LanguageRuntime

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

Moving BreakpointPrecondition to a forward-declarable place sounds good to me.



================
Comment at: source/Target/ObjCLanguageRuntime.cpp:379
+void ObjCLanguageRuntime::SetBreakpointExceptionPrecondition(
+    BreakpointSP breakpoint, LanguageType language, bool throw_bp) {
+  if (!throw_bp)
----------------
Shouldn't you be checking the language here or something. Given that you're iterating over all plugins, won't this set the precondition unconditionally (:P) on all exception breakpoints?


================
Comment at: source/Target/ObjCLanguageRuntime.cpp:384
+      new ObjCLanguageRuntime::ObjCExceptionPrecondition());
+  if (!precondition_sp)
+    return;
----------------
`new` doesn't fail


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63181/new/

https://reviews.llvm.org/D63181