[Lldb-commits] [PATCH] D62505: Fix multiple module loaded with the same UUID

António Afonso via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue May 28 07:19:01 PDT 2019

aadsm added a comment.

Interesting, I did miss that comment when I checked that class. This is something @clayborg was concerned with when I discussed this solution with him. The main reason I was not keen in having multiple load addresses for a section is because that would change the GetLoadAddress to return an array instead of an addr_t or some kind of mechanism to be able to correctly resolve the load address of an Address (felt like too big of a change for what it looks like an edge case?). 
So I preferred to look at this situation (of 2 modules with the exact same data) as a coincidence and be ok with parsing the same data twice. It is actually not clear to me why Samsung ships these vndks if they're an exact copy of the system ones.

  rG LLVM Github Monorepo



More information about the lldb-commits mailing list