[Lldb-commits] [PATCH] D62505: Fix multiple module loaded with the same UUID

Tue May 28 01:59:58 PDT 2019

labath added a reviewer: jingham.
labath added a subscriber: jingham.
labath added a comment.

I agree we need to support a module being loaded multiple times, but I'm not sure if this is the right way to achieve that. I mean, if two files are exactly the same, then it should be fine (and even preferable) to download them just once, store them under a single entry (based on the UUID) in the module cache, and parse their symbols just once. It seems like somebody even intended for us to support a module being loaded multiple times as there is this TODO https://github.com/llvm-mirror/lldb/blob/1b2170d0116d52a219574780e7eb01043c3712e1/source/Target/SectionLoadList.cpp#L50 in the SectionLoadList class.

However, this is not an area I'm super familiar with. Maybe @jingham knows more about this?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62505/new/

https://reviews.llvm.org/D62505