[Lldb-commits] [lldb] r361565 - [lldb] followup fix for https://reviews.llvm.org/D62305

[Richard Smith via lldb-commits]

On Thu, 23 May 2019 at 15:39, Konrad Kleine via lldb-commits <
lldb-commits at lists.llvm.org> wrote:

> Author: kwk
> Date: Thu May 23 15:39:13 2019
> New Revision: 361565
>
> URL: http://llvm.org/viewvc/llvm-project?rev=361565&view=rev
> Log:
> [lldb] followup fix for https://reviews.llvm.org/D62305
>
> Summary:
> Fixing this error on windows build bot:
>
> ```
> E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(21):
> error C2440: 'initializing': cannot convert from 'nullptr' to
> 'lldb::thread_result_t'
> E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(21):
> note: A native nullptr can only be converted to bool or, using
> reinterpret_cast, to an integral type
> E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(21):
> error C2439: 'lldb_private::HostNativeThreadBase::m_result': member could
> not be initialized
> E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\include\lldb/Host/HostNativeThreadBase.h(48):
> note: see declaration of 'lldb_private::HostNativeThreadBase::m_result'
> E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(24):
> error C2440: 'initializing': cannot convert from 'nullptr' to
> 'lldb::thread_result_t'
> E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(24):
> note: A native nullptr can only be converted to bool or, using
> reinterpret_cast, to an integral type
> E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(24):
> error C2439: 'lldb_private::HostNativeThreadBase::m_result': member could
> not be initialized
> E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\include\lldb/Host/HostNativeThreadBase.h(48):
> note: see declaration of 'lldb_private::HostNativeThreadBase::m_result'
> E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(40):
> error C2440: '=': cannot convert from 'nullptr' to 'lldb::thread_result_t'
> E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(40):
> note: A native nullptr can only be converted to bool or, using
> reinterpret_cast, to an integral type
> E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(50):
> error C2440: '=': cannot convert from 'nullptr' to 'lldb::thread_result_t'
> E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(50):
> note: A native nullptr can only be converted to bool or, using
> reinterpret_cast, to an integral type
> ```
>
> see
> http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/5050/steps/build/logs/stdio
>
> Reviewers: stella.stamenova, JDevlieghere
>
> Reviewed By: JDevlieghere
>
> Subscribers: lldb-commits
>
> Tags: #lldb
>
> Differential Revision: https://reviews.llvm.org/D62337
>
> Modified:
>     lldb/trunk/source/Host/common/HostNativeThreadBase.cpp
>
> Modified: lldb/trunk/source/Host/common/HostNativeThreadBase.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/HostNativeThreadBase.cpp?rev=361565&r1=361564&r2=361565&view=diff
>
> ==============================================================================
> --- lldb/trunk/source/Host/common/HostNativeThreadBase.cpp (original)
> +++ lldb/trunk/source/Host/common/HostNativeThreadBase.cpp Thu May 23
> 15:39:13 2019
> @@ -18,10 +18,10 @@ using namespace lldb;
>  using namespace lldb_private;
>
>  HostNativeThreadBase::HostNativeThreadBase()
> -    : m_thread(LLDB_INVALID_HOST_THREAD), m_result(0) {}
> +    : m_thread(LLDB_INVALID_HOST_THREAD), m_result({}) {}
>
>  HostNativeThreadBase::HostNativeThreadBase(thread_t thread)
> -    : m_thread(thread), m_result(0) {}
> +    : m_thread(thread), m_result({}) {}
>

This change breaks the build with Clang:

third_party/llvm/llvm/tools/lldb/source/Host/common/HostNativeThreadBase.cpp:21:43:
error: cannot initialize non-class type 'lldb::thread_result_t' (aka 'void
*') with a parenthesized initializer list
    : m_thread(LLDB_INVALID_HOST_THREAD), m_result({}) {}
                                          ^        ~~


>  lldb::thread_t HostNativeThreadBase::GetSystemHandle() const {
>    return m_thread;
> @@ -37,7 +37,7 @@ bool HostNativeThreadBase::IsJoinable()
>
>  void HostNativeThreadBase::Reset() {
>    m_thread = LLDB_INVALID_HOST_THREAD;
> -  m_result = 0;
> +  m_result = {};
>  }
>
>  bool HostNativeThreadBase::EqualsThread(lldb::thread_t thread) const {
> @@ -47,7 +47,7 @@ bool HostNativeThreadBase::EqualsThread(
>  lldb::thread_t HostNativeThreadBase::Release() {
>    lldb::thread_t result = m_thread;
>    m_thread = LLDB_INVALID_HOST_THREAD;
> -  m_result = 0;
> +  m_result = {};
>
>    return result;
>  }
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190523/8962588d/attachment.html>