<div dir="ltr"><div dir="ltr">On Thu, 23 May 2019 at 15:39, Konrad Kleine via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: kwk<br>
Date: Thu May 23 15:39:13 2019<br>
New Revision: 361565<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=361565&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=361565&view=rev</a><br>
Log:<br>
[lldb] followup fix for <a href="https://reviews.llvm.org/D62305" rel="noreferrer" target="_blank">https://reviews.llvm.org/D62305</a><br>
<br>
Summary:<br>
Fixing this error on windows build bot:<br>
<br>
```<br>
E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(21): error C2440: 'initializing': cannot convert from 'nullptr' to 'lldb::thread_result_t'<br>
E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(21): note: A native nullptr can only be converted to bool or, using reinterpret_cast, to an integral type<br>
E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(21): error C2439: 'lldb_private::HostNativeThreadBase::m_result': member could not be initialized<br>
E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\include\lldb/Host/HostNativeThreadBase.h(48): note: see declaration of 'lldb_private::HostNativeThreadBase::m_result'<br>
E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(24): error C2440: 'initializing': cannot convert from 'nullptr' to 'lldb::thread_result_t'<br>
E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(24): note: A native nullptr can only be converted to bool or, using reinterpret_cast, to an integral type<br>
E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(24): error C2439: 'lldb_private::HostNativeThreadBase::m_result': member could not be initialized<br>
E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\include\lldb/Host/HostNativeThreadBase.h(48): note: see declaration of 'lldb_private::HostNativeThreadBase::m_result'<br>
E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(40): error C2440: '=': cannot convert from 'nullptr' to 'lldb::thread_result_t'<br>
E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(40): note: A native nullptr can only be converted to bool or, using reinterpret_cast, to an integral type<br>
E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(50): error C2440: '=': cannot convert from 'nullptr' to 'lldb::thread_result_t'<br>
E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\source\Host\common\HostNativeThreadBase.cpp(50): note: A native nullptr can only be converted to bool or, using reinterpret_cast, to an integral type<br>
```<br>
<br>
see <a href="http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/5050/steps/build/logs/stdio" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/5050/steps/build/logs/stdio</a><br>
<br>
Reviewers: stella.stamenova, JDevlieghere<br>
<br>
Reviewed By: JDevlieghere<br>
<br>
Subscribers: lldb-commits<br>
<br>
Tags: #lldb<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D62337" rel="noreferrer" target="_blank">https://reviews.llvm.org/D62337</a><br>
<br>
Modified:<br>
    lldb/trunk/source/Host/common/HostNativeThreadBase.cpp<br>
<br>
Modified: lldb/trunk/source/Host/common/HostNativeThreadBase.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/HostNativeThreadBase.cpp?rev=361565&r1=361564&r2=361565&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/HostNativeThreadBase.cpp?rev=361565&r1=361564&r2=361565&view=diff</a><br>
==============================================================================<br>
--- lldb/trunk/source/Host/common/HostNativeThreadBase.cpp (original)<br>
+++ lldb/trunk/source/Host/common/HostNativeThreadBase.cpp Thu May 23 15:39:13 2019<br>
@@ -18,10 +18,10 @@ using namespace lldb;<br>
 using namespace lldb_private;<br>
<br>
 HostNativeThreadBase::HostNativeThreadBase()<br>
-    : m_thread(LLDB_INVALID_HOST_THREAD), m_result(0) {}<br>
+    : m_thread(LLDB_INVALID_HOST_THREAD), m_result({}) {}<br>
<br>
 HostNativeThreadBase::HostNativeThreadBase(thread_t thread)<br>
-    : m_thread(thread), m_result(0) {}<br>
+    : m_thread(thread), m_result({}) {}<br></blockquote><div><br></div><div>This change breaks the build with Clang:</div><div><br></div><div>third_party/llvm/llvm/tools/lldb/source/Host/common/HostNativeThreadBase.cpp:21:43: error: cannot initialize non-class type 'lldb::thread_result_t' (aka 'void *') with a parenthesized initializer list<br>    : m_thread(LLDB_INVALID_HOST_THREAD), m_result({}) {}<br>                                          ^        ~~<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
 lldb::thread_t HostNativeThreadBase::GetSystemHandle() const {<br>
   return m_thread;<br>
@@ -37,7 +37,7 @@ bool HostNativeThreadBase::IsJoinable()<br>
<br>
 void HostNativeThreadBase::Reset() {<br>
   m_thread = LLDB_INVALID_HOST_THREAD;<br>
-  m_result = 0;<br>
+  m_result = {};<br>
 }<br>
<br>
 bool HostNativeThreadBase::EqualsThread(lldb::thread_t thread) const {<br>
@@ -47,7 +47,7 @@ bool HostNativeThreadBase::EqualsThread(<br>
 lldb::thread_t HostNativeThreadBase::Release() {<br>
   lldb::thread_t result = m_thread;<br>
   m_thread = LLDB_INVALID_HOST_THREAD;<br>
-  m_result = 0;<br>
+  m_result = {};<br>
<br>
   return result;<br>
 }<br>
<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
</blockquote></div></div>