[Lldb-commits] [PATCH] D61779: FuncUnwinders: General clean up and optimization

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri May 10 07:20:14 PDT 2019


clayborg added inline comments.


================
Comment at: include/lldb/Symbol/FuncUnwinders.h:117
+  class LazyPlan {
+    lldb::UnwindPlanSP m_plan_sp;
+
----------------
maybe use:

```
llvm::Optional<lldb::UnwindPlanSP> m_plan_sp;
```

Then just check if it has no value, and if so compute and set it either to a valid shared pointer or an empty one?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61779/new/

https://reviews.llvm.org/D61779





More information about the lldb-commits mailing list