[Lldb-commits] [PATCH] D61733: Breakpad: Generate unwind plans from STACK CFI records

[Pavel Labath via Phabricator via lldb-commits]

labath updated this revision to Diff 198993.
labath added a comment.

- use a yaml form of the minidump file (as it is possible to do that as of today)
- fix the CHECK-NOT directives in the test and the two issues they caught
- found a way to trigger one of the asserts with an invalid input, so I demote it into a "return nullptr"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61733/new/

https://reviews.llvm.org/D61733

Files:
  lit/SymbolFile/Breakpad/Inputs/stack-cfi-parsing.syms
  lit/SymbolFile/Breakpad/Inputs/stack-cfi-parsing.yaml
  lit/SymbolFile/Breakpad/stack-cfi-parsing.test
  source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp
  source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61733.198993.patch
Type: text/x-patch
Size: 13530 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190510/38d0738e/attachment-0001.bin>