[Lldb-commits] [PATCH] D61733: Breakpad: Generate unwind plans from STACK CFI records

[Pavel Labath via Phabricator via lldb-commits]

labath marked 3 inline comments as done.
labath added inline comments.


================
Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:472
+  if (!unwind_rules.empty())
+    LLDB_LOG(log, "Could not parse `{0}` as an unwind rule.", unwind_rules);
+  return true;
----------------
amccarth wrote:
> Should the function return `false` when there are leftover unparsable rules?  The other error cases seem to do that.
Good point. In fact this should have been caught by the test, if it was written properly, but I forgot the colon after the `CHECK-NOT` directive, which meant it was ignored by FileCheck. :/
Fixing that found another case where I was mistakenly returning a "valid" unwind plan for invalid input, which I have fixed too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61733/new/

https://reviews.llvm.org/D61733