[Lldb-commits] [PATCH] D61360: Initialization: remove ObjectContainer from Common
Saleem Abdulrasool via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu May 2 09:02:48 PDT 2019
compnerd updated this revision to Diff 197797.
compnerd marked 6 inline comments as done.
compnerd added a comment.
address feedback
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61360/new/
https://reviews.llvm.org/D61360
Files:
source/API/SystemInitializerFull.cpp
source/Initialization/CMakeLists.txt
source/Initialization/SystemInitializerCommon.cpp
Index: source/Initialization/SystemInitializerCommon.cpp
===================================================================
--- source/Initialization/SystemInitializerCommon.cpp
+++ source/Initialization/SystemInitializerCommon.cpp
@@ -101,16 +101,10 @@
process_gdb_remote::ProcessGDBRemoteLog::Initialize();
- // Initialize plug-ins
- ObjectContainerBSDArchive::Initialize();
-
EmulateInstructionARM::Initialize();
EmulateInstructionMIPS::Initialize();
EmulateInstructionMIPS64::Initialize();
- // Apple/Darwin hosted plugins
- ObjectContainerUniversalMachO::Initialize();
-
#if defined(__linux__) || defined(__FreeBSD__) || defined(__NetBSD__)
ProcessPOSIXLog::Initialize();
#endif
@@ -124,14 +118,11 @@
void SystemInitializerCommon::Terminate() {
static Timer::Category func_cat(LLVM_PRETTY_FUNCTION);
Timer scoped_timer(func_cat, LLVM_PRETTY_FUNCTION);
- ObjectContainerBSDArchive::Terminate();
EmulateInstructionARM::Terminate();
EmulateInstructionMIPS::Terminate();
EmulateInstructionMIPS64::Terminate();
- ObjectContainerUniversalMachO::Terminate();
-
#if defined(_MSC_VER)
ProcessWindowsLog::Terminate();
#endif
Index: source/Initialization/CMakeLists.txt
===================================================================
--- source/Initialization/CMakeLists.txt
+++ source/Initialization/CMakeLists.txt
@@ -17,8 +17,6 @@
lldbPluginInstructionARM
lldbPluginInstructionMIPS
lldbPluginInstructionMIPS64
- lldbPluginObjectContainerBSDArchive
- lldbPluginObjectContainerMachOArchive
lldbPluginProcessGDBRemote
${EXTRA_PLUGINS}
${LLDB_SYSTEM_LIBS}
Index: source/API/SystemInitializerFull.cpp
===================================================================
--- source/API/SystemInitializerFull.cpp
+++ source/API/SystemInitializerFull.cpp
@@ -58,6 +58,8 @@
#include "Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.h"
#include "Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.h"
#include "Plugins/MemoryHistory/asan/MemoryHistoryASan.h"
+#include "Plugins/ObjectContainer/BSD-Archive/ObjectContainerBSDArchive.h"
+#include "Plugins/ObjectContainer/Universal-Mach-O/ObjectContainerUniversalMachO.h"
#include "Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.h"
#include "Plugins/ObjectFile/ELF/ObjectFileELF.h"
#include "Plugins/ObjectFile/Mach-O/ObjectFileMachO.h"
@@ -129,6 +131,9 @@
ObjectFileMachO::Initialize();
ObjectFilePECOFF::Initialize();
+ ObjectContainerBSDArchive::Initialize();
+ ObjectContainerUniversalMachO::Initialize();
+
ScriptInterpreterNone::Initialize();
#ifndef LLDB_DISABLE_PYTHON
@@ -360,6 +365,9 @@
ObjectFileMachO::Terminate();
ObjectFilePECOFF::Terminate();
+ ObjectContainerBSDArchive::Terminate();
+ ObjectContainerUniversalMachO::Terminate();
+
// Now shutdown the common parts, in reverse order.
SystemInitializerCommon::Terminate();
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61360.197797.patch
Type: text/x-patch
Size: 2942 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190502/9784de72/attachment-0001.bin>
More information about the lldb-commits
mailing list