[Lldb-commits] [PATCH] D61360: Initialization: remove ObjectContainer from Common

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: source/API/CMakeLists.txt:99-100
     lldbUtility
+    lldbPluginObjectContainerBSDArchive
+    lldbPluginObjectContainerMachOArchive
     ${LLDB_ALL_PLUGINS}
----------------
xiaobai wrote:
> These should get sucked into LLDB_ALL_PLUGINS right?
Yes, they will be.


================
Comment at: source/API/SystemInitializerFull.cpp:132-133
 
+  ObjectContainerBSDArchive::Initialize();
+  ObjectContainerUniversalMachO::Initialize();
+
----------------
xiaobai wrote:
> You need to include the headers for these classes
And remove them from `SystemInitializerCommon.h`


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61360/new/

https://reviews.llvm.org/D61360