[Lldb-commits] [lldb] r359730 - [lldb-server] Remove lldb-server's dependency on Core

[Pavel Labath via lldb-commits]

On 01/05/2019 23:41, Alex Langford via lldb-commits wrote:
> Author: xiaobai
> Date: Wed May  1 14:41:40 2019
> New Revision: 359730
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=359730&view=rev
> Log:
> [lldb-server] Remove lldb-server's dependency on Core
> 
> No need to directly link against Core, as lldb-server doesn't directly
> use it.
> 
> Modified:
>      lldb/trunk/tools/lldb-server/CMakeLists.txt
>      lldb/trunk/tools/lldb-server/LLDBServerUtilities.cpp
>      lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp
> 
> Modified: lldb/trunk/tools/lldb-server/CMakeLists.txt
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-server/CMakeLists.txt?rev=359730&r1=359729&r2=359730&view=diff
> ==============================================================================
> --- lldb/trunk/tools/lldb-server/CMakeLists.txt (original)
> +++ lldb/trunk/tools/lldb-server/CMakeLists.txt Wed May  1 14:41:40 2019
> @@ -64,7 +64,6 @@ add_lldb_tool(lldb-server
>   
>       LINK_LIBS
>         lldbBase
> -      lldbCore
>         lldbHost
>         lldbInitialization
>         lldbInterpreter
> 
> Modified: lldb/trunk/tools/lldb-server/LLDBServerUtilities.cpp
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-server/LLDBServerUtilities.cpp?rev=359730&r1=359729&r2=359730&view=diff
> ==============================================================================
> --- lldb/trunk/tools/lldb-server/LLDBServerUtilities.cpp (original)
> +++ lldb/trunk/tools/lldb-server/LLDBServerUtilities.cpp Wed May  1 14:41:40 2019
> @@ -8,7 +8,6 @@
>   
>   #include "LLDBServerUtilities.h"
>   
> -#include "lldb/Core/StreamFile.h"
>   #include "lldb/Utility/Args.h"
>   #include "lldb/Utility/Log.h"
>   #include "lldb/Utility/StreamString.h"
> 
> Modified: lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp?rev=359730&r1=359729&r2=359730&view=diff
> ==============================================================================
> --- lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp (original)
> +++ lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp Wed May  1 14:41:40 2019
> @@ -22,7 +22,6 @@
>   #include "LLDBServerUtilities.h"
>   #include "Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h"
>   #include "Plugins/Process/gdb-remote/ProcessGDBRemoteLog.h"
> -#include "lldb/Core/PluginManager.h"
>   #include "lldb/Host/ConnectionFileDescriptor.h"
>   #include "lldb/Host/FileSystem.h"
>   #include "lldb/Host/HostGetOpt.h"
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
> 

Nice catch.