[Lldb-commits] [PATCH] D61406: Watchpoint test + stop-command-source-on-error fix combo

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere created this revision.
JDevlieghere added reviewers: davide, sgraenitz, friss.
Herald added subscribers: teemperor, jfb.
Herald added a project: LLDB.

The original intention was to change the watchpoint Python test to a lit test. While doing so, I found a situation where stop-command-source-on-error was being ignored. Since the new test also tests the fix for the CommandObjectCommands, I figured I'd keep them in a single patch.

- I converted the test to lit because it is flaky on GreenDragon.
- The problem with the command object is that we didn't differentiate between the boolean value not being set, and the value being set to either true or false. If the value isn't set, we'd calculate it in the command interpreter based on the global options. With the old approach, we'd always set the value to the default of the option, which is not what the user wanted.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D61406

Files:
  lldb/lit/Watchpoint/Inputs/main.cpp
  lldb/lit/Watchpoint/SetErrorCases.test
  lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_set_command/TestWatchpointSetErrorCases.py
  lldb/source/Commands/CommandObjectCommands.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61406.197649.patch
Type: text/x-patch
Size: 8555 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190501/daf2bbab/attachment-0001.bin>