[Lldb-commits] [PATCH] D61240: Implement GetSystemIncludeDirectories for macOS

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp:244
+  case lldb::eLanguageTypeObjC_plus_plus:
+    return {sys_root + "/usr/include/"};
+  default:
----------------
aprantl wrote:
> aprantl wrote:
> > I'm not 100% sure if that is how Clang header search works, but I believe that these paths should be returned relative to the sysroot, no?
> ... and we should set sysroot separately.
Doing it this way may work but it would be different from how a regular clang invocation works, and that is prone to subtle bugs.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61240/new/

https://reviews.llvm.org/D61240