[Lldb-commits] [PATCH] D61240: Implement GetSystemIncludeDirectories for macOS

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Apr 29 12:25:43 PDT 2019


aprantl added inline comments.


================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp:244
+  case lldb::eLanguageTypeObjC_plus_plus:
+    return {sys_root + "/usr/include/"};
+  default:
----------------
aprantl wrote:
> I'm not 100% sure if that is how Clang header search works, but I believe that these paths should be returned relative to the sysroot, no?
... and we should set sysroot separately.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61240/new/

https://reviews.llvm.org/D61240





More information about the lldb-commits mailing list