[Lldb-commits] [PATCH] D61191: Editline: Fix an msan error

[Christos Zoulas via lldb-commits]

Yes, you don't need to NULL terminate the argument list now.
Here's a link to the commit:
http://mail-index.netbsd.org/source-changes/2019/04/26/msg105454.html <http://mail-index.netbsd.org/source-changes/2019/04/26/msg105454.html>

Best,

christos

> On Apr 29, 2019, at 7:39 AM, Pavel Labath <pavel at labath.sk> wrote:
> 
> On 26/04/2019 18:56, Christos Zoulas wrote:
>> On Apr 26,  3:11pm, reviews at reviews.llvm.org (Pavel Labath via Phabricator) wrote:
>> -- Subject: [PATCH] D61191: Editline: Fix an msan error
>> |
>> | --b1_b299efcc557883c5ff30a5eebc16e12b
>> | Content-Type: text/plain; charset=us-ascii
>> | Content-Transfer-Encoding: quoted-printable
>> |
>> | labath created this revision.
>> | labath added reviewers: christos, krytarowski, davide.
>> |
>> | Despite the documentation for the el_get(EL_GETTC) function claiming the
>> | vararg part is (const char *name, void *value), in reality the function
>> | expects the vararg list to be terminated by a null pointer, which can be
>> | clearly seen by examining the source code. Although this is mostly
>> | bening because the extra values are not used it any way, it still lights
>> | up as an error when running the tests under msan.
>> |
>> | Work around this quirk by adding an explicit nullptr to the end of the
>> | argument list.
>> |
>> |
>> | https://reviews.llvm.org/D61191
>> fixed, thanks!
>> christos
> 
> 
> Oooh, thanks for the super-fast fix.
> 
> Just to confirm, by "fixed" you mean that it should now not be needed to terminate the vararg list with a null pointer?
> 
> Do you have anything (a revision, version number or something) that I can leave as a trail to future maintainers to remove this workaround when the fixed libedit becomes more widely available?
> 
> pl

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190429/d3a6f637/attachment-0001.html>